Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between Clear used CSS / Critical Images vs. Clean […] buttons #6533

Closed
hanna-meda opened this issue Apr 1, 2024 · 2 comments · Fixed by #6551
Closed

Inconsistency between Clear used CSS / Critical Images vs. Clean […] buttons #6533

hanna-meda opened this issue Apr 1, 2024 · 2 comments · Fixed by #6551
Assignees
Labels
effort: [XS] < 1 day of estimated development time module: user interface priority: low Issues that can wait severity: minor Defect that does not affect functionality type: bug Indicates an unexpected problem or unintended behavior
Milestone

Comments

@hanna-meda
Copy link
Contributor

Before submitting an issue please check that you’ve completed the following steps:

Made sure you’re on the latest version: 3.16-alpha1 ✓
Used the search feature to ensure that the bug hasn’t been reported before ✓

Describe the bug
Currently, we have a couple of discrepancies in UI regarding the Clear used CSS / Critical Images accessible from either Admin top bar or from WPR Dashboard - Quick Actions section.

Case 1:
While RUCSS enabled, visit a Page URL while being logged in and check the Admin bar.
Notice that the button reads "Clean Used CSS of this URL".
Screenshot 2024-04-01 at 13 34 42

Case 2:
With RUCSS disabled, go to the WPR Dashboard and inspect the Quick Actions section.
Notice that the button for Critical Images Cache reads "Clean Critical Images" (meanwhile in Admin bar it is used "Clear").
Screenshot 2024-04-01 at 13 26 31

Expected behavior
The button should read in all places and for all cases, "Clear" instead of "Clean".

@hanna-meda hanna-meda added type: bug Indicates an unexpected problem or unintended behavior priority: low Issues that can wait severity: minor Defect that does not affect functionality module: user interface labels Apr 1, 2024
@hanna-meda hanna-meda added this to the 3.16 milestone Apr 1, 2024
@jeawhanlee
Copy link
Contributor

jeawhanlee commented Apr 8, 2024

Reproduce the problem ✅
I can see the problem in the code.

Identify the root cause ✅
We use Clean here & here instead of Clear

Scope a solution ✅
We need to update the text here & here to use Clear

Estimate the effort ✅
[XS]

@MathieuLamiot
Copy link
Contributor

MathieuLamiot added a commit that referenced this issue Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: [XS] < 1 day of estimated development time module: user interface priority: low Issues that can wait severity: minor Defect that does not affect functionality type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
3 participants