Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6533: Inconsistency between Clear used CSS / Critical Images vs. Clean […] buttons #6551

Conversation

jeawhanlee
Copy link
Contributor

Description

Fixes the inconsistency in text between Clear & Clean.

Fixes #6533

Documentation

User documentation

Explain how this code impacts users.

Technical documentation

Explain how this code works. Diagram & drawings are welcomed.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

New dependencies

List any new dependencies that are required for this change.

Risks

List possible performance & security issues or risks, and explain how they have been mitigated.

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Documentation

  • I prepared the user documentation for the feature/enhancement and shared it in the PR or the GitHub issue.
  • The user documentation covers new/changed entry points (endpoints, WP hooks, configuration files, ...).
  • I prepared the technical documentation if needed, and shared it in the PR or the GitHub issue.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.
  • I listed the introduced external dependencies explicitely on the PR.
  • I validated the repo-specific guidelines from CONTRIBUTING.md.

Observability

  • I handled errors when needed.
  •  I wrote user-facing messages that are understandable and provide actionable feedbacks.
  • I prepared ways to observe the implemented system (logs, data, etc.).

Risks

  •  I explicitely mentioned performance risks in the PR.
  • I explicitely mentioned security risks in the PR.

@jeawhanlee jeawhanlee self-assigned this Apr 9, 2024
@jeawhanlee jeawhanlee added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement module: user interface labels Apr 9, 2024
…inconsistency-btw-clear-used-css-and-clear-critical-images
@jeawhanlee jeawhanlee requested a review from a team April 9, 2024 15:15
@jeawhanlee jeawhanlee marked this pull request as ready for review April 9, 2024 15:15
@MathieuLamiot MathieuLamiot merged commit 03bf1a6 into feature/lcp-above-the-fold-optimization Apr 12, 2024
9 checks passed
@MathieuLamiot MathieuLamiot deleted the fix/6533-inconsistency-btw-clear-used-css-and-clear-critical-images branch April 12, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: user interface type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency between Clear used CSS / Critical Images vs. Clean […] buttons
3 participants