Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6539 Update container to v4 #6542

Merged
merged 9 commits into from
Apr 16, 2024
Merged

Conversation

remyperona
Copy link
Contributor

Description

Update the container to version 4, and update the code to match with the upgrade path.

Fixes #6539

Documentation

User documentation

Should have no impact for users.

Technical documentation

Notable changes:

  • share() method removed, replaced by addShared()
  • Service provider now implements a provides() method

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

New dependencies

  • PSR container to v1.1.1 & league container to v4.2

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.

@remyperona remyperona self-assigned this Apr 4, 2024
@remyperona remyperona marked this pull request as ready for review April 5, 2024 20:33
@remyperona remyperona requested a review from a team April 5, 2024 20:33
@remyperona remyperona added this pull request to the merge queue Apr 16, 2024
Merged via the queue into develop with commit abee9d8 Apr 16, 2024
9 of 10 checks passed
@remyperona remyperona deleted the enhancement/container-v4 branch April 16, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Container dependency to v4
2 participants