Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sass do not store result in DB bug #6557

Merged
merged 13 commits into from
Apr 25, 2024
Merged

Fixed sass do not store result in DB bug #6557

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5970f74
:chore: Add data attribute to --fixes :bug: #6521
Khadreal Apr 11, 2024
a34a5d1
fix PHP warning
remyperona Apr 10, 2024
ad5706f
:chore: Add data attribute to --fixes :bug: #6521
Khadreal Apr 11, 2024
13f31b0
Merge branch 'bug/saas-results-db#6521' of github.com:wp-media/wp-roc…
Khadreal Apr 12, 2024
853e0cd
:chore: Add beacon header to request
Khadreal Apr 12, 2024
7376232
Merge commit 'e31b05b9bb505b7955627c49b1f53acd503f2060' into bug/saas…
MathieuLamiot Apr 12, 2024
9caaef7
:closes: Fixed test and update minify js
Khadreal Apr 15, 2024
eded04b
Merge branch 'bug/saas-results-db#6521' of github.com:wp-media/wp-roc…
Khadreal Apr 15, 2024
1b5ca43
Resolve test issue :feat:
Khadreal Apr 15, 2024
d74e2a6
Fixed test
Khadreal Apr 15, 2024
d3e45fd
Fixed code conflict
Khadreal Apr 24, 2024
550e05d
Fixed failing test and code conflict
Khadreal Apr 25, 2024
6748e41
fixed integration test typo
Khadreal Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions assets/js/lcp-beacon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ function LCPCandidates(count) {
if (imageURL !== null) {
// Insert element into topCandidates in descending order of area
for (let i = 0; i < topCandidates.length; i++) {

if (area > topCandidates[i].area) {
topCandidates.splice(i, 0, { element, area, imageURL });
topCandidates.length = Math.min(
Expand Down Expand Up @@ -133,10 +133,15 @@ async function main() {
await fetch(rocket_lcp_data.ajax_url, {
method: "POST",
credentials: 'same-origin',
body: data
body: data,
headers: {
'wpr-saas-no-intercept': true
}
})
.then((response) => response.json())
.then((data) => {
const beaconscript = document.querySelector('[data-name="wpr-lcp-beacon"]');
beaconscript.setAttribute('beacon-completed', 'true');
console.log(data);
})
.catch((error) => {
Expand Down
2 changes: 1 addition & 1 deletion inc/Engine/Media/AboveTheFold/Frontend/Controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ public function inject_beacon( $html, $url, $is_mobile ): string {
$script_url = rocket_get_constant( 'WP_ROCKET_ASSETS_JS_URL' ) . 'lcp-beacon' . $min . '.js';

// Create the script tag.
$script_tag = "<script src='{$script_url}' async></script>"; // phpcs:ignore WordPress.WP.EnqueuedResources.NonEnqueuedScript
$script_tag = "<script data-name=\"wpr-lcp-beacon\" src='{$script_url}' async></script>"; // phpcs:ignore WordPress.WP.EnqueuedResources.NonEnqueuedScript

// Append the script tag just before the closing body tag.
return str_replace( '</body>', $inline_script . $script_tag . '</body>', $html );
Expand Down
Loading