Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6574 Display console message only in debug mode #6595

Merged

Conversation

remyperona
Copy link
Contributor

@remyperona remyperona commented Apr 25, 2024

Description

Display the console message for the LCP script only when in DEBUG bode

Fixes #6574

Documentation

Technical documentation

Also fixed a number of tests that were having side effects.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.

Observability

  • I handled errors when needed.
  • I prepared ways to observe the implemented system (logs, data, etc.).

@remyperona remyperona self-assigned this Apr 25, 2024
Copy link

codacy-production bot commented Apr 25, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -0.10%) 100.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9a9e1f4) 36970 14164 38.31%
Head commit (7304078) 36977 (+7) 14165 (+1) 38.31% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6595) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@remyperona remyperona marked this pull request as ready for review April 25, 2024 20:32
@remyperona remyperona requested a review from a team April 25, 2024 20:32
@remyperona remyperona added this to the 3.16 milestone Apr 25, 2024
@remyperona remyperona added the type: enhancement Improvements that slightly enhance existing functionality and are fast to implement label Apr 25, 2024
@Khadreal Khadreal merged commit a76706b into feature/lcp-above-the-fold-optimization Apr 26, 2024
13 checks passed
@Khadreal Khadreal deleted the fix/6574-beacon-console branch April 26, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.16 - Remove console.log of the beacon script when the debug mode is not enabled
3 participants