-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #7064 CDN Compatibility for host fonts locally #7169
Closes #7064 CDN Compatibility for host fonts locally #7169
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Thanks for the PR, @remyperona. |
Good catch, I fixed this in the PR that is handling clearing of the data 1ca09d9 |
Should this go back to QA then? @remyperona @hanna-meda |
Checked the fix for this on 1ca09d9 but it can still be reproduced for some pages. @remyperona, if you'll continue to fix it on task/7071-clear-data PR, then this task can be closed as done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Fixes #7064
Apply CDN URL on local fonts CSS & fonts files
Type of change
Detailed scenario
Technical description
Documentation
Use the existing filters we have
rocket_css_url
androcket_css_content
to apply CDN.Mandatory Checklist
Code validation
Code style