Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CICD-428] Remove notify step from e2e deploy #117

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

apmatthews
Copy link
Member

@apmatthews apmatthews commented Feb 6, 2025

JIRA Ticket

CICD-428

What Are We Doing Here

Removes the notify step of our e2e workflow. The failures in this workflow have consistently been unrelated to the action itself and are therefore not actionable. Instead, they indicate an issue with some other service we depend on (GitHub, Docker Hub, SSH Gateway, WPE User Portal). These services are either out of our control or are already monitored in other ways.

Bonus: this gets rid of a dependency on voxmedia/github-action-slack-notify-build, which has been deprecated.

@apmatthews apmatthews requested a review from a team as a code owner February 6, 2025 22:46
Copy link

changeset-bot bot commented Feb 6, 2025

⚠️ No Changeset found

Latest commit: 0ca4cb5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@apmatthews apmatthews merged commit 6a055dc into main Feb 6, 2025
4 checks passed
@apmatthews apmatthews deleted the CICD/428-remove-slack-notifications branch February 6, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants