Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change AdvantageScope wmclass #512

Merged

Conversation

spacey-sooty
Copy link
Contributor

No description provided.

@@ -1036,7 +1036,7 @@ await Task.Run(() =>
}, token);
}

CreateLinuxShortcut("AdvantageScope (WPILib)", frcYear, "AdvantageScope", token);
CreateLinuxShortcut("AdvantageScope (WPILib)", frcYear, "AdvantageScope (WPILib)", token);
CreateLinuxShortcut("Elastic (WPILib)", frcYear, "Elastic", token);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Elastic use just "Elastic" for its wmclass?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would guess that Elastic is just using the default WM_CLASS (probably "Elastic"), though I haven't confirmed. This change is related to this issue, since the 6328 and WPILib versions of AdvantageScope are now differentiated.

@PeterJohnson PeterJohnson merged commit f920f40 into wpilibsuite:main Jan 11, 2025
7 checks passed
@spacey-sooty spacey-sooty deleted the advantagescope-new-wmclass branch January 11, 2025 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants