Skip to content

Commit

Permalink
[epilogue] Revert "Add a measure's symbol to its name when logged by …
Browse files Browse the repository at this point in the history
…Epilogue (#7535)" (#7652)

This reverts commit 469bb32.

The approach used has issues due to the fact unit symbols often have a literal / in them,
which causes issues with NT topic visualization.

A better approach would be to use topic metadata.
  • Loading branch information
oh-yes-0-fps authored Jan 7, 2025
1 parent 2de03c9 commit 995bc98
Showing 1 changed file with 3 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -198,10 +198,9 @@ default <S> void log(String identifier, Collection<S> value, Struct<S> struct) {
*
* @param identifier the identifier of the data field
* @param value the new value of the data field
* @param <U> the dimension of the unit
*/
default <U extends Unit> void log(String identifier, Measure<U> value) {
log(identifier, value, value.baseUnit());
default void log(String identifier, Measure<?> value) {
log(identifier, value.baseUnitMagnitude());
}

/**
Expand All @@ -213,7 +212,7 @@ default <U extends Unit> void log(String identifier, Measure<U> value) {
* @param <U> the dimension of the unit
*/
default <U extends Unit> void log(String identifier, Measure<U> value, U unit) {
log(identifier + " (" + unit.symbol() + ")", value.in(unit));
log(identifier, value.in(unit));
}

/**
Expand Down

0 comments on commit 995bc98

Please sign in to comment.