[datalog] Move DataLogReaderThread from glass to new libdatalog #7641
+1,531
−254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Turner <[email protected]>
This changes the way deferred proxy is implemented to not use the deprecated ProxyCommand constructor. This function serves a good purpose that should be kept IMO. The constructor was confusing but this is just good syntactic sugar over `defer(() -> supplier.get().asProxy())`. Signed-off-by: Jade Turner <[email protected]>
Column in Field Drawings is labeled X-Rotation, but I believe it should be Y-Rotation so have reflected that here. We'll fix in a TU if this is correct.
Original image was flipped when it should have been rotated.
github-actions
bot
added
component: wpiutil
…#7643) Too many people don't realize that glass/simgui field2d can load pathweaver JSON field files since it's hidden.
PeterJohnson
reviewed
Jan 6, 2025
…Epilogue (wpilibsuite#7535)" (wpilibsuite#7652) This reverts commit 469bb32. The approach used has issues due to the fact unit symbols often have a literal / in them, which causes issues with NT topic visualization. A better approach would be to use topic metadata.
DeltaDizzy
force-pushed
the
datalogreader-to-wpiutil
branch
from
d7e1188 to
92897bb
Compare
DeltaDizzy
force-pushed
the
datalogreader-to-wpiutil
branch
from
92897bb to
d429635
Compare
DeltaDizzy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the major DataLog backend API (reading and writing) is split between wpiutil and glass. In the interest of allowing code that wants to use these APIs to not need to link to glass and declutter wpiutil, all of those APIs are moved to a new library named "libdatalog".