Don't export any data symbols

wpilibsuite · Aug 18, 2024 · 2dbcd43 · 2dbcd43
1 parent 6ed2c9b
commit 2dbcd43
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 1 deletion.
diff --git a/DefFileGenerator/bindexplib.cpp b/DefFileGenerator/bindexplib.cpp
@@ -311,8 +311,9 @@ class DumpSymbols
                    symbol.find("$iexit_thunk") == std::string::npos &&
                    symbol.find("$exit_thunk") == std::string::npos)) {
                 if (!pSymbolTable->Type && (SectChar & IMAGE_SCN_MEM_WRITE)) {
+                  // WPILib. Don't export any data symbols. We don't want to have to worry about dllimport
                   // Read only (i.e. constants) must be excluded
-                  this->DataSymbols.insert(symbol);
+                  //this->DataSymbols.insert(symbol);
                 } else {
                   if (pSymbolTable->Type || !(SectChar & IMAGE_SCN_MEM_READ) ||
                       (SectChar & IMAGE_SCN_MEM_EXECUTE) ||

diff --git a/src/main/resources/arm64/DefFileGenerator.exe b/src/main/resources/arm64/DefFileGenerator.exe
diff --git a/src/main/resources/x64/DefFileGenerator.exe b/src/main/resources/x64/DefFileGenerator.exe