Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint #28

Merged
merged 8 commits into from
Sep 24, 2024
Merged

Add eslint #28

merged 8 commits into from
Sep 24, 2024

Conversation

SamCarlberg
Copy link
Member

This project was in sore need of consistent styling

  • No semicolons
  • All strings must be double quoted, except for string templates and strings that would need to escape a double quote char
  • Consistent indentation levels
  • Whitespace within braces (imports, templates, object literals, etc)
  • EOL at EOF

@SamCarlberg
Add eslint; linting updates; bump libn from ES2021 to ES2022
14b5724
@SamCarlberg
More linting
9b3a076
@SamCarlberg
Add linting rules for quotation marks
c2e9aac 
Require double quotes, except for templates or string literals that contain a double quote char (in which case single quotes or backticks are permitted, to avoid needing to escape)

Only allow quoted property names if any property name in the object needs to be quoted (and then all properties must be quoted)
@SamCarlberg
Sort linting rules alphabetically
9c1719c
@SamCarlberg
Add eslint CI check
b2a0027
@SamCarlberg
Deliberately break linting to check CI action
817f854
@SamCarlberg
Output git patch with automatic fixes on failure
0286702
@SamCarlberg
Revert "Deliberately break linting to check CI action"
b042c8e 
This reverts commit 817f854.
@SamCarlberg SamCarlberg merged commit b558026 into wpilibsuite:main Sep 24, 2024
1 check passed
@SamCarlberg SamCarlberg deleted the eslint branch September 24, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SamCarlberg