Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2024 files #6

Merged
merged 15 commits into from
Sep 27, 2024
Merged

Add 2024 files #6

merged 15 commits into from
Sep 27, 2024

Conversation

jasondaming
Copy link
Member

No description provided.

@jasondaming jasondaming changed the title Add CTRE 2024 files Add 2024 files May 22, 2024
check.py Outdated Show resolved Hide resolved
@PeterJohnson
Copy link
Member

Why is Phoenix6 using "frcjson"?

@jasondaming
Copy link
Member Author

I think the answer should come from @JCaporuscio but my understanding is that because we want a different json file for each version that his is how those are automatically generated. I don't think that has to be the case for the future but it may be? The only real requirement that we have is that the name cannot clash per year with another "vendor".

Keep in mind that this is not the actual name that the user sees. That is specified in the file (fileName key) in this case "Phoenix6.json"

@JCaporuscio
Copy link
Member

JCaporuscio commented May 29, 2024

That file naming is how our vendordeps are internally generated and archived, so to grab multiple specific versions all at once it's (currently) the only option.

In the case where we add each json version as we go (say, a PR each time we release) the naming would match the current public-facing naming (ie Phoenix6-[version].json).

For an initial batch add like this, since there's only half a dozen files or so I would highly recommend renaming them to match the public-facing naming to avoid future confusion. So "Phoenix6-[version].json" or "Phoenix5-[version]".json depending on which lib it is.

@PeterJohnson PeterJohnson merged commit 6a40ab1 into wpilibsuite:master Sep 27, 2024
1 check passed
@jasondaming jasondaming deleted the ctre2024 branch September 28, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants