Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional support for XRP/Romi #621

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Additional support for XRP/Romi #621

merged 1 commit into from
Sep 22, 2023

Conversation

zhiquanyeo
Copy link
Member

This PR adds additional support for the XRP (and Romi) including

  • Utilizing the XRP plugin for XRP projects (depends on Add support for XRP plugin GradleRIO#673)
  • Adding support for an extravendordeps property in the template/example JSON listings
  • Correctly including the Romi/XRP vendordeps if necessary for a particular template/example

@sciencewhiz
Copy link
Contributor

This fixes #508 and #528 right?

@zhiquanyeo
Copy link
Member Author

It fixes #508 for sure. but I don't think it does anything for #528 (at least intentionally).

@PeterJohnson PeterJohnson merged commit b790545 into wpilibsuite:main Sep 22, 2023
6 checks passed
@sciencewhiz sciencewhiz mentioned this pull request Nov 10, 2023
Closed
wpineth added a commit to wpineth/vscode-wpilib that referenced this pull request Mar 29, 2024
@wpineth
Additional support for XRP/Romi (wpilibsuite#621)
35c692e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterJohnson PeterJohnson PeterJohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhiquanyeo @sciencewhiz @PeterJohnson