fix: don't use try catch

wrideveloper · Nov 24, 2024 · 847e308 · 847e308
1 parent 12724e8
commit 847e308
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 13 deletions.
diff --git a/routes/index.tsx b/routes/index.tsx
@@ -17,18 +17,14 @@ export const handler: Handlers = {
 			case "PUT": {
 				const originalUrl = form.get("original_url") as string;
 				const customUrl = form.get("custom_url") as string;
-				try {
-					const customised = await customiseShortenedUrl(
-						originalUrl,
-						customUrl,
-					);
-					return ctx.render({
-						url: customised,
-						isUpdated: true,
-					});
-				} catch {
+				const customised = await customiseShortenedUrl(originalUrl, customUrl);
+				if (!customised) {
 					return ctx.render({ error: "Customised url already exists" });
 				}
+				return ctx.render({
+					url: customised,
+					isUpdated: true,
+				});
 			}
 			default: {
 				const originalUrl = form.get("url") as string;

diff --git a/services/shortener.ts b/services/shortener.ts
@@ -21,9 +21,9 @@ export async function customiseShortenedUrl(original: string, customised: string
 	// trim customised url
 	const customisedKey = ["url", customised.trim()];
 
-	// check if customised already exists
-	if (await kv.get(customisedKey)) {
-		throw new Error("Customised url already exists");
+	const existingCustomised = await kv.get(customisedKey);
+	if (existingCustomised) {
+		return null;
 	}
 
 	await kv