Add translation capability + French translations + Fix build #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryonakano
reviewed
Jul 16, 2019
Co-Authored-By: Ryo Nakano <[email protected]>
This reverts commit 3eee319.
This reverts commit ea87fb2.
NathanBnm
changed the title
|
@thebaer could you please review this? |
|
@NathanBnm Sorry for not getting to this earlier, my focus has been elsewhere. Is this still valid? If so, I'll take a look. |
|
@thebaer I have to check first but if you have time to review it would be great |
|
@thebaer this is now ready for review 😄 |
thebaer
reviewed
Nov 19, 2021
|
|
||
| run_target('build', command: 'meson/build-cli.sh') |
There was a problem hiding this comment.
Does the CLI still get built when building the app now?
There was a problem hiding this comment.
I added this line back but don't see it in action. Any idea?
There was a problem hiding this comment.
Writeas CLI is not being installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I made everything ready for translations and added French translations 😄 I had to adjust the build to fit with the elementary guidelines. This closes #23.
App translations are located in the
pofolder andappdataanddesktopare located in theextra/pofolder. This is more clear like that.There's only the error messages that I didn't add to translation files 'cause I don't know where they are located.
This PR is ready for review