-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add flatpak builds #30
Open
BrainBlasted
wants to merge
24
commits into
master
Choose a base branch
from
T678-flatpak-ci
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the app used "writeas-gtk" as the app id. This was invalid according to freedesktop specifications. See https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-id-generic for details on what an App ID should be.
Creates a flatpak manifest to build the app. Does not yet build the writeas-cli. Related to T663
These are the directories flatpak can create while building an app. Since they should not be committed, they belong in the gitignore.
Flatpak doesn't support running extra commands, so we need to make the cli build it's own target. This is made optional since the cli doesn't always need to be shipped with the app. Related to T663
This was missed during the consolidation of repositiories. Since the app has different executable names for the different builds, the app_id cannot be used as the "exec" line unconditionally.
This run_target no longer exists.
Fixes publishing and copies the post link to the clipboard.
Allows for flatpak users to have persistent drafts, and for the bundled cli to access them.
Required for saving to work within flatpaks. Does not affect non-flatpak usage. Related to T663
Needed to make sure we can create, read, and write to this directory.
Sets ups build stage for flatpak builds. For T678
Travis defaults to Ruby if a language is not specified, which results in a build failure. For T678
Docker is required for the flatpak build. For T678
Based on the tips from travis-ci/travis-ci#2646 For T678
This ensures that Travis doesn't think we're using Ruby. For T678
Ensure that the flatpak directories exist. For T678
Ensures that the docker container will be able to access the repository on the host. For T678
Carries over the original configuration. For T678
Required to specify a host directory. For T678
fusermount not being executable can cause build failures for flatpak builds. For T678
Needed for Fuse to work for flatpak. For T678
Incorrectly spelled a flag. For T678
This ensures that the CI is building from the current PR instead of git master. For T678
flatpak-builder needs the path to the manifest. To avoid duplication we use an env variable. For T678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds flatpak builds to the CI. I'm not too familiar with Travis, so for some reason this currently only builds the flatpak. Based on changes from #29