Fixes for opus, comment field & misc #283
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
local.properties is clearly not meant to be present in version control (as stated in the file itself). Remove it, as otherwise the paths to sdk/ndk need to be modified manually. Signed-off-by: h67ma <[email protected]>
Compilation fails because advance_file_descriptor() is undeclared. Move it above its usage. Signed-off-by: h67ma <[email protected]>
Current configuration of ffmpeg does not support opus containers and streams. In stream_component_open(), avcodec_find_decoder() for codec id AV_CODEC_ID_OPUS returns NULL. Add the --enable-libopus flag to ffmpeg-android-maker.sh. Note: not sure about the branch with openssl enabled. build_ffmpeg_with_ssl.sh does not exist. Signed-off-by: h67ma <[email protected]>
In current implementation, tags from all streams are being put in a single map. This can cause overwriting tags from other streams. One specific example is the "comment" field in audio files. If a coverart (attached picture) is present, its stream usually contains a "comment" field with a value of e.g. "Cover (front)". The "comment" field is also commonly used in audio streams. Audio stream tags are parsed before any attached pictures (video streams) in get_metadata_internal(). If the file has video streams with "comment" tags, those tags will overwrite the original value from audio stream. From a user's perspective, the value from audio stream is more preferable than a coverart annotation. Add flags to av_dict_copy() calls to not overwrite previous keys. Note: this is more of a workaround than a fix. A proper, comprehensive fix would be to redesign the whole library to output an array of maps, one for each stream. Signed-off-by: h67ma <[email protected]>
|
Patch 4/5 fixes #263 |
wseemann_media_FFmpegMediaMetadataRetriever_setDataSourceAndHeaders copies from char ptr to char array without allocating space for the terminating null byte. This sometimes results in file uri containing random garbage at the end after the buffer is passed to MediaMetadataRetriever::setDataSource and subsequent functions. Fix it by allocating a buffer of proper size (strlen(src) + 1). Signed-off-by: h67ma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.