Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cookie] Introduce of context keystore for GetCookie, SetCookie Fn for signing #198

Merged
merged 4 commits into from
Dec 13, 2024
Merged

[Cookie] Introduce of context keystore for GetCookie, SetCookie Fn for signing #198

merged 4 commits into from
Dec 13, 2024

Conversation

Thumimku
Copy link
Contributor

@Thumimku Thumimku commented Dec 10, 2024 •
edited
Loading

Purpose

$
Logic will create context keystore if not exists

Public Issue: wso2/product-is#21985
Todo

  • Merge FW PR
  • Bump FW

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12308796162

@codecov Codecov
Copy link

codecov bot commented Dec 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.34%. Comparing base (cb7e045) to head (bd40752).
Report is 8 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #198   +/-   ##
=========================================
  Coverage     39.34%   39.34%           
  Complexity      405      405           
=========================================
  Files           111      111           
  Lines          3604     3604           
  Branches        410      410           
=========================================
  Hits           1418     1418           
  Misses         2030     2030           
  Partials        156      156
Flag Coverage Δ
unit 43.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12308796162
Status: failure

@Thumimku Thumimku changed the title [Cookie] Introduce of context keystore for GetCookie, SetCookie Fn [Cookie] Introduce of context keystore for GetCookie, SetCookie Fn for signing Dec 13, 2024
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12310047045

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12310047045
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12310299392

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12310299392
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Dec 13, 2024
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12310299392

@Thumimku Thumimku merged commit 9b51a9b into wso2-extensions:master Dec 13, 2024
4 checks passed
@indeewari indeewari mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RushanNanayakkara RushanNanayakkara RushanNanayakkara left review comments

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@janakamarasena janakamarasena janakamarasena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Thumimku @jenkins-is-staging @janakamarasena @RushanNanayakkara