Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict cross-tenant Multi Attribute Login Identifier lookups #201

Conversation

HasiniSama
Copy link
Contributor

Purpose

Restrict cross-tenant Multi-Attribute Login Identifier lookups to prevent unauthorized cross-tenant resolutions.

Goals

  • Ensure login identifier resolution occurs only within the current tenant's context.
  • Provide clearer debug messages for easier issue identification.

Approach

  • Enforced tenant domain validation in the resolveMultiAttributeLoginIdentifier method.

@HasiniSama HasiniSama force-pushed the cross-tenant-multi-att-login-identifier branch 2 times, most recently from 6fa821f to bc3bec8 Compare January 10, 2025 05:39
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.75%. Comparing base (17b92fc) to head (6de9beb).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #201   +/-   ##
=========================================
  Coverage     39.75%   39.75%           
  Complexity      408      408           
=========================================
  Files           111      111           
  Lines          3675     3675           
  Branches        416      416           
=========================================
  Hits           1461     1461           
  Misses         2058     2058           
  Partials        156      156           
Flag Coverage Δ
unit 43.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HasiniSama HasiniSama force-pushed the cross-tenant-multi-att-login-identifier branch 2 times, most recently from 2a76e94 to e8d333c Compare January 10, 2025 07:53
@HasiniSama HasiniSama force-pushed the cross-tenant-multi-att-login-identifier branch from e8d333c to 6de9beb Compare January 10, 2025 12:26
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12710126896

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12710126896
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12710126896

@ThaminduDilshan ThaminduDilshan merged commit edd8125 into wso2-extensions:master Jan 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants