Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve console & myaccount callback urls based on a toml config #2301

Merged

Conversation

UdeshAthukorala
Copy link
Contributor

@UdeshAthukorala UdeshAthukorala commented Dec 13, 2023

Proposed changes in this pull request

  • Resolve console & myaccount callback urls based on a toml config

    Toml Config

    [console]
    callback_url = "https://localhost:9001/t/{TENANT_DOMAIN}/console"
    access_url = "https://localhost:9001/t/{TENANT_DOMAIN}/console"
    
    [myaccount]
    callback_url = "https://localhost:9000/t/{TENANT_DOMAIN}/myaccount"
    access_url = "https://localhost:9000/t/{TENANT_DOMAIN}/myaccount"
    
    • Can also use regex pattern also as a callback URL regex.
      ex:
    [console]
    callback_url = "regexp=(https://localhost:9000/t/(.*)/console|https://localhost:9000/console)"
    
    [myaccount]
    callback_url = "regexp=(https://localhost:9000/t/(.*)/myaccount|https://localhost:9000/myaccount)"
    

When should this PR be merged

TODO

  • Bump framework version

Related Issue

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7357407607

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7357407607
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7357524147

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7357407607

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7357524147
Status: failure

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7357407607
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7357996073

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7357996073
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7357996073

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7357996073
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7359044927

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7359044927
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7362674473

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7362674473
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7362674473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants