Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove session termination by userID to restrict token revocation of applications not associated for app Role #2323

Conversation

ZiyamSanthosh
Copy link
Contributor

  • According to the previous implementation, if role update related events are triggered, the tokens and sessions belongs to the user are revoked and terminated.
  • With the new application role concept, we restricted the token revocation logic to revoke only the tokens generated for the associated app of the specific app role.
  • But, the session termination happens based on the userID where all active session of the relevant user will be terminated and the tokens are revoked.
  • If multiple application tokens shares the same session, when the session is terminated, irrelevant tokens will also be revoked.
  • Since we are anyway revoking the relevant tokens, avoiding the session termination will not be an issue. Because, anyhow when an API call is made through the application with the revoked token, authentication will fail and in that time, the session will get expired.

Related issue:

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7567624544

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7567624544
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7567980515

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7567980515
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7567980515

@ZiyamSanthosh ZiyamSanthosh merged commit 65af2e6 into wso2-extensions:master Jan 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants