Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce method to handle claim mappings with IdP group to role assignment resolving #2682

Merged

Conversation

SujanSanjula96
Copy link
Contributor

@SujanSanjula96 SujanSanjula96 commented Jan 22, 2025

Proposed changes in this pull request

#Subject to be used in grant handlers which handles the custom claims in grant handlers itself.

Need to bump framework version after merging wso2/carbon-identity-framework#6305

Issue - wso2/product-is#21009

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12970128613

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 5.26316% with 18 lines in your changes missing coverage. Please review.

Project coverage is 56.04%. Comparing base (a59a31c) to head (e377de0).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...g/wso2/carbon/identity/oauth2/util/ClaimsUtil.java 0.00% 18 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2682      +/-   ##
============================================
+ Coverage     55.87%   56.04%   +0.17%     
+ Complexity     8479     8395      -84     
============================================
  Files           654      654              
  Lines         49017    48095     -922     
  Branches       9656     9490     -166     
============================================
- Hits          27386    26954     -432     
+ Misses        17746    17314     -432     
+ Partials       3885     3827      -58     
Flag Coverage Δ
unit 39.50% <5.26%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12970128613
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12971117818

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12971117818
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12971117818

@SujanSanjula96
Copy link
Contributor Author

Unit tests will be added in a separate PR.

@SujanSanjula96 SujanSanjula96 merged commit 868b725 into wso2-extensions:master Jan 26, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants