Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve data validation for app native auth response #2690

Closed
wants to merge 1 commit into from

Conversation

janakamarasena
Copy link
Contributor

Previous there were no authenticators that sent additional data without any required params. But with the introduction of push based authentication since the actual authentication happens in a decoupled manner the auth request for push auth doesn't have any required params. However the push authenticator needs to transmit additional data.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12945394827

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.48%. Comparing base (72b70c8) to head (299dbdf).

Files with missing lines Patch % Lines
...ntity/oauth/endpoint/api/auth/ApiAuthnHandler.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2690      +/-   ##
============================================
+ Coverage     55.34%   55.48%   +0.13%     
+ Complexity     8668     8494     -174     
============================================
  Files           647      647              
  Lines         50709    49798     -911     
  Branches       9956     9648     -308     
============================================
- Hits          28063    27628     -435     
+ Misses        18589    18180     -409     
+ Partials       4057     3990      -67     
Flag Coverage Δ
unit 39.50% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12945394827
Status: failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants