Improve sub org application deletion when accessing through tenant pe…

…rspective
wso2-extensions · Nov 1, 2024 · 4db89ee · 4db89ee
1 parent 2333d0d
commit 4db89ee
Showing 1 changed file with 19 additions and 16 deletions.
diff --git a/...identity/organization/management/application/listener/FragmentApplicationMgtListener.java b/...identity/organization/management/application/listener/FragmentApplicationMgtListener.java
@@ -131,23 +131,26 @@ public boolean isEnable() {
     public boolean doPreCreateApplication(ServiceProvider serviceProvider, String tenantDomain, String userName)
             throws IdentityApplicationManagementException {
 
-        try {
-            String organizationId = getOrganizationManager().resolveOrganizationId(tenantDomain);
-            int organizationDepthInHierarchy =
-                    getOrganizationManager().getOrganizationDepthInHierarchy(organizationId);
-            if (isSubOrganization(organizationDepthInHierarchy) &&
-                    !isSharedAppFromInternalProcess(serviceProvider, tenantDomain)) {
-                throw new IdentityApplicationManagementClientException(
-                        ERROR_CODE_SUB_ORG_CANNOT_CREATE_APP.getCode(),
-                        ERROR_CODE_SUB_ORG_CANNOT_CREATE_APP.getMessage());
-            }
-        } catch (OrganizationManagementClientException e) {
-            if (LOG.isDebugEnabled()) {
-                LOG.debug("Organization not found for the tenant: " + tenantDomain);
+        if (StringUtils.isEmpty(PrivilegedCarbonContext.getThreadLocalCarbonContext()
+                .getApplicationResidentOrganizationId())) {
+            try {
+                String organizationId = getOrganizationManager().resolveOrganizationId(tenantDomain);
+                int organizationDepthInHierarchy =
+                        getOrganizationManager().getOrganizationDepthInHierarchy(organizationId);
+                if (isSubOrganization(organizationDepthInHierarchy) &&
+                        !isSharedAppFromInternalProcess(serviceProvider, tenantDomain)) {
+                    throw new IdentityApplicationManagementClientException(
+                            ERROR_CODE_SUB_ORG_CANNOT_CREATE_APP.getCode(),
+                            ERROR_CODE_SUB_ORG_CANNOT_CREATE_APP.getMessage());
+                }
+            } catch (OrganizationManagementClientException e) {
+                if (LOG.isDebugEnabled()) {
+                    LOG.debug("Organization not found for the tenant: " + tenantDomain);
+                }
+            } catch (OrganizationManagementException e) {
+                throw new IdentityApplicationManagementException(
+                        "An error occurred while getting depth of the organization", e);
             }
-        } catch (OrganizationManagementException e) {
-            throw new IdentityApplicationManagementException(
-                    "An error occurred while getting depth of the organization", e);
         }
         return true;
     }