-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate user store domain of the parent user invitation flow #402
Validate user store domain of the parent user invitation flow #402
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
=============================================
- Coverage 41.53% 25.76% -15.78%
- Complexity 218 339 +121
=============================================
Files 30 50 +20
Lines 1678 4142 +2464
Branches 187 476 +289
=============================================
+ Hits 697 1067 +370
- Misses 938 2996 +2058
- Partials 43 79 +36 ☔ View full report in Codecov by Sentry. |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11392719570
e653cc1
to
9b9a9d1
Compare
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11473150644
}, | ||
{ | ||
true, "true", true, false | ||
false, null, "false", true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same test cases, order has changed for an experiment. Might revert back
|
||
// Mocking Role List | ||
RoleBasicInfo role1 = new RoleBasicInfo("1", "Role1"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These methods have used private mocking and need to rewrite test cases.
public void testGetUserGroups() throws Exception { | ||
|
||
// Mocking IdentityTenantUtil.getTenantId static method | ||
when(IdentityTenantUtil.getTenantId(anyString())).thenReturn(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These methods have used private mocking and need to rewrite test cases.
Purpose
In this effort the following improvements are made.
Related Issues