Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to register custom org discovery types #458

Merged

Conversation

sahandilshan
Copy link
Contributor

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.08%. Comparing base (ce56080) to head (19dffec).
Report is 136 commits behind head on main.

Files with missing lines Patch % Lines
.../config/service/OrganizationConfigManagerImpl.java 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #458      +/-   ##
============================================
- Coverage     44.48%   42.08%   -2.40%     
- Complexity     1269     1304      +35     
============================================
  Files           163      164       +1     
  Lines          8812     9475     +663     
  Branches       1072     1221     +149     
============================================
+ Hits           3920     3988      +68     
- Misses         4564     5142     +578     
- Partials        328      345      +17     
Flag Coverage Δ
unit 32.67% <90.47%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sahandilshan sahandilshan force-pushed the custom-org-discovery-impl branch from 3963d7b to 0f8563d Compare February 8, 2025 16:41
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13233194747

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13233194747
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13233194747

@sahandilshan sahandilshan merged commit 1966413 into wso2-extensions:main Feb 10, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants