Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new authenticator configs for user defined authentication extensions. #6108

Merged

Conversation

Thisara-Welmilla
Copy link
Contributor

@Thisara-Welmilla Thisara-Welmilla commented Nov 6, 2024

Issue:

With this PR, following changes will be added.

  • Introduce new models for endpoint configurations of the user defined authenticators.
  • Introduced new authenticator configuration UserDefinedFederatedAuthenticator model to for user defined fed authenticators extending FederatedAuthenticatorConfig class.
  • Introduced new authenticator configuration UserDefinedLocalAuthenticator model to for user defined fed authenticators extending LocalAuthenticatorConfig class.
  • Improve action auithentication class model.
  • Cover unit tests for new models.

@Thisara-Welmilla Thisara-Welmilla force-pushed the add-user-defined-auth-config branch 3 times, most recently from 1e739c9 to b57cbda Compare November 6, 2024 09:33
@Thisara-Welmilla Thisara-Welmilla requested review from Yoshani and removed request for Yoshani November 6, 2024 09:52
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 78.87324% with 15 lines in your changes missing coverage. Please review.

Project coverage is 40.76%. Comparing base (c0ba5cc) to head (0c77d92).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
...entity/action/management/model/Authentication.java 62.50% 6 Missing and 3 partials ⚠️
...model/UserDefinedFederatedAuthenticatorConfig.java 57.14% 3 Missing ⚠️
...mon/model/UserDefinedLocalAuthenticatorConfig.java 66.66% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6108      +/-   ##
============================================
- Coverage     40.98%   40.76%   -0.22%     
+ Complexity    14698    14485     -213     
============================================
  Files          1764     1768       +4     
  Lines        119164   117713    -1451     
  Branches      20860    20305     -555     
============================================
- Hits          48836    47984     -852     
+ Misses        63008    62451     -557     
+ Partials       7320     7278      -42     
Flag Coverage Δ
unit 25.03% <78.87%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thisara-Welmilla Thisara-Welmilla force-pushed the add-user-defined-auth-config branch from b57cbda to 020a81a Compare November 6, 2024 11:58
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-user-defined-auth-config branch 4 times, most recently from 326d228 to 44bf32f Compare November 7, 2024 06:51
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-user-defined-auth-config branch from 44bf32f to 453f02d Compare November 7, 2024 07:25
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-user-defined-auth-config branch 3 times, most recently from 52c9d10 to 649809f Compare November 8, 2024 03:08
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-user-defined-auth-config branch from 649809f to 0c77d92 Compare November 8, 2024 03:08
Copy link

sonarqubecloud bot commented Nov 8, 2024

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11735720931

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11735720931
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11735720931

@Thisara-Welmilla Thisara-Welmilla merged commit 4a30de8 into wso2:master Nov 8, 2024
5 checks passed
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11739603482

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11739603482
Status: failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants