Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for managing the user defined local authenticators #6172

Merged

Conversation

Thisara-Welmilla
Copy link
Contributor

@Thisara-Welmilla Thisara-Welmilla commented Dec 3, 2024

@Thisara-Welmilla Thisara-Welmilla force-pushed the add-custom-local-auth-mgt-support branch from 9f9126d to 7964563 Compare December 3, 2024 05:20
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 85.37118% with 67 lines in your changes missing coverage. Please review.

Project coverage is 40.97%. Comparing base (37745ca) to head (be755b7).
Report is 114 commits behind head on master.

Files with missing lines Patch % Lines
...on/internal/ApplicationCommonServiceComponent.java 0.00% 20 Missing ⚠️
...ommon/dao/impl/AuthenticatorManagementDAOImpl.java 85.49% 17 Missing and 2 partials ⚠️
...common/dao/impl/AuthenticatorManagementFacade.java 85.45% 7 Missing and 1 partial ⚠️
...ommon/dao/impl/CacheBackedAuthenticatorMgtDAO.java 84.21% 0 Missing and 6 partials ⚠️
.../common/util/AuthenticatorMgtExceptionBuilder.java 90.69% 1 Missing and 3 partials ⚠️
...UserDefinedAuthenticatorEndpointConfigManager.java 95.77% 3 Missing ⚠️
...cation/common/ApplicationAuthenticatorService.java 94.44% 1 Missing and 1 partial ⚠️
...lication/common/cache/AuthenticatorCacheEntry.java 66.66% 2 Missing ⚠️
...pplication/common/cache/AuthenticatorCacheKey.java 75.00% 1 Missing and 1 partial ⚠️
...eption/AuthenticatorMgtServerRuntimeException.java 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6172      +/-   ##
============================================
- Coverage     45.33%   40.97%   -4.36%     
- Complexity    13832    15754    +1922     
============================================
  Files          1614     1813     +199     
  Lines         99700   126473   +26773     
  Branches      16833    22520    +5687     
============================================
+ Hits          45196    51826    +6630     
- Misses        47860    67038   +19178     
- Partials       6644     7609     +965     
Flag Coverage Δ
unit 28.29% <85.37%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thisara-Welmilla Thisara-Welmilla force-pushed the add-custom-local-auth-mgt-support branch 8 times, most recently from 9acc1e1 to be4aa7a Compare December 3, 2024 12:45
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-custom-local-auth-mgt-support branch 2 times, most recently from 6e5b690 to c14d0e4 Compare December 16, 2024 10:28
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-custom-local-auth-mgt-support branch from c14d0e4 to b4c7215 Compare December 16, 2024 10:33
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-custom-local-auth-mgt-support branch from 3969687 to 26398d9 Compare December 16, 2024 13:00
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-custom-local-auth-mgt-support branch from 26398d9 to 7dd69e3 Compare December 16, 2024 13:02
ashanthamara
ashanthamara previously approved these changes Dec 16, 2024
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12354079484

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12354079484
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12354079484

@Thisara-Welmilla Thisara-Welmilla merged commit fce4e30 into wso2:master Dec 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants