Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Application authenticator retrieving methods in authentication framework. #6365

Merged
merged 15 commits into from
Jan 27, 2025

Conversation

Thisara-Welmilla
Copy link
Contributor

Issue:

Refactor Application authenticator retrieving methods in authentication framework to support retrieving ApplicationAuthenticators for User defined authenticator configs.

@Thisara-Welmilla Thisara-Welmilla force-pushed the new-adapter-service branch 2 times, most recently from 495adff to dc433f3 Compare January 25, 2025 17:48
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 38.41463% with 101 lines in your changes missing coverage. Please review.

Project coverage is 46.46%. Comparing base (eea8893) to head (500670d).
Report is 51 commits behind head on master.

Files with missing lines Patch % Lines
...internal/core/ApplicationAuthenticatorManager.java 66.07% 17 Missing and 2 partials ⚠️
...uthentication/framework/AuthenticationService.java 22.72% 17 Missing ⚠️
.../authentication/framework/util/FrameworkUtils.java 11.76% 15 Missing ⚠️
...ramework/handler/step/impl/DefaultStepHandler.java 18.75% 12 Missing and 1 partial ⚠️
...ework/config/model/OptimizedApplicationConfig.java 0.00% 9 Missing ⚠️
.../framework/internal/FrameworkServiceComponent.java 0.00% 8 Missing ⚠️
...n/framework/cache/AuthenticationContextLoader.java 0.00% 7 Missing ⚠️
...ork/config/model/OptimizedAuthenticatorConfig.java 0.00% 5 Missing ⚠️
...work/config/loader/UIBasedConfigurationLoader.java 66.66% 2 Missing and 2 partials ⚠️
.../config/builder/FileBasedConfigurationBuilder.java 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6365      +/-   ##
============================================
- Coverage     46.77%   46.46%   -0.32%     
+ Complexity    15015    14831     -184     
============================================
  Files          1733     1728       -5     
  Lines        104595   104192     -403     
  Branches      18749    18634     -115     
============================================
- Hits          48925    48410     -515     
- Misses        48702    48889     +187     
+ Partials       6968     6893      -75     
Flag Coverage Δ
unit 30.26% <38.03%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12967853595

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12967853595
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12971684845

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12971684845
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12979049463

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12979049463
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12979049463

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12980730065

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12980730065
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12981433365

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12981433365
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12982203452

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12982203452
Status: failure

@Thisara-Welmilla
Copy link
Contributor Author

Prevoius integration builder was passed and later only added unit tests #6365 (review)

Also locally ran those tests and got passed them
Screenshot 2025-01-27 at 12 16 12

malithie
malithie previously approved these changes Jan 27, 2025
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12984867639

@Thisara-Welmilla Thisara-Welmilla force-pushed the new-adapter-service branch 2 times, most recently from 6f35460 to f7d1536 Compare January 27, 2025 09:08
@malithie malithie merged commit 4f2de3d into wso2:master Jan 27, 2025
3 checks passed
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12984867639
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12984867639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants