-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Application authenticator retrieving methods in authentication framework. #6365
Conversation
495adff
to
dc433f3
Compare
dc433f3
to
5a3bd8b
Compare
...2/carbon/identity/application/authentication/framework/ApplicationAuthenticationService.java
Outdated
Show resolved
Hide resolved
...2/carbon/identity/application/authentication/framework/ApplicationAuthenticationService.java
Outdated
Show resolved
Hide resolved
...ava/org/wso2/carbon/identity/application/authentication/framework/AuthenticationService.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6365 +/- ##
============================================
- Coverage 46.77% 46.46% -0.32%
+ Complexity 15015 14831 -184
============================================
Files 1733 1728 -5
Lines 104595 104192 -403
Branches 18749 18634 -115
============================================
- Hits 48925 48410 -515
- Misses 48702 48889 +187
+ Partials 6968 6893 -75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e0bb538
to
17a90eb
Compare
PR builder started |
...2/carbon/identity/application/authentication/framework/ApplicationAuthenticationService.java
Show resolved
Hide resolved
.../carbon/identity/application/authentication/framework/cache/AuthenticationContextLoader.java
Outdated
Show resolved
Hide resolved
.../identity/application/authentication/framework/config/loader/UIBasedConfigurationLoader.java
Outdated
Show resolved
Hide resolved
...n/identity/application/authentication/framework/config/model/OptimizedApplicationConfig.java
Outdated
Show resolved
Hide resolved
...g/wso2/carbon/identity/application/authentication/framework/AuthenticatorAdapterService.java
Outdated
Show resolved
Hide resolved
...g/wso2/carbon/identity/application/authentication/framework/AuthenticatorAdapterService.java
Outdated
Show resolved
Hide resolved
...g/wso2/carbon/identity/application/authentication/framework/AuthenticatorAdapterService.java
Outdated
Show resolved
Hide resolved
...tity/application/authentication/framework/internal/core/ApplicationAuthenticatorManager.java
Outdated
Show resolved
Hide resolved
.../java/org/wso2/carbon/identity/application/authentication/framework/util/FrameworkUtils.java
Outdated
Show resolved
Hide resolved
PR builder completed |
PR builder started |
...2/carbon/identity/application/authentication/framework/ApplicationAuthenticationService.java
Outdated
Show resolved
Hide resolved
PR builder completed |
...rbon/identity/application/authentication/framework/handler/step/impl/DefaultStepHandler.java
Show resolved
Hide resolved
6eefa53
to
98a9317
Compare
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12979049463
e4ca996
to
d165648
Compare
PR builder started |
PR builder completed |
d165648
to
b440b28
Compare
PR builder started |
PR builder completed |
b440b28
to
8c121a4
Compare
PR builder started |
PR builder completed |
Prevoius integration builder was passed and later only added unit tests #6365 (review) |
PR builder started |
6f35460
to
f7d1536
Compare
f7d1536
to
500670d
Compare
Quality Gate passedIssues Measures |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12984867639
Issue:
Refactor Application authenticator retrieving methods in authentication framework to support retrieving ApplicationAuthenticators for User defined authenticator configs.