Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SELECT db queries for custom defined authenticators. #6415

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

Thisara-Welmilla
Copy link
Contributor

@Thisara-Welmilla Thisara-Welmilla commented Feb 2, 2025

Issue:

The current DB queries which retrieve user defiend local authenticators and user defined federated authenticators are not considering IDP type. This PR fixes user defined authentication retrieval DB queries.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13097808179

@Thisara-Welmilla Thisara-Welmilla changed the title Fix get db queries for custom defined authenticators. Fix SELECT db queries for custom defined authenticators. Feb 2, 2025
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.16%. Comparing base (b78d6ad) to head (4036ef9).
Report is 23 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6415      +/-   ##
============================================
+ Coverage     45.99%   47.16%   +1.17%     
+ Complexity    15457    15234     -223     
============================================
  Files          1744     1745       +1     
  Lines        110303   105379    -4924     
  Branches      20091    19272     -819     
============================================
- Hits          50729    49698    -1031     
+ Misses        52307    48646    -3661     
+ Partials       7267     7035     -232     
Flag Coverage Δ
unit 30.52% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13097808179
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13097808179

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13107913441

Copy link

sonarqubecloud bot commented Feb 3, 2025

@Thisara-Welmilla Thisara-Welmilla merged commit 43d5b29 into wso2:master Feb 3, 2025
5 checks passed
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13107913441
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13107913441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants