-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SELECT db queries for custom defined authenticators. #6415
Conversation
PR builder started |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6415 +/- ##
============================================
+ Coverage 45.99% 47.16% +1.17%
+ Complexity 15457 15234 -223
============================================
Files 1744 1745 +1
Lines 110303 105379 -4924
Branches 20091 19272 -819
============================================
- Hits 50729 49698 -1031
+ Misses 52307 48646 -3661
+ Partials 7267 7035 -232
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13097808179
...t/org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/dao/IdPManagementFacade.java
Outdated
Show resolved
Hide resolved
f555310
to
4036ef9
Compare
PR builder started |
|
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13107913441
Issue:
The current DB queries which retrieve user defiend local authenticators and user defined federated authenticators are not considering IDP type. This PR fixes user defined authentication retrieval DB queries.