-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add console role listener #7416
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7416 +/- ##
==========================================
+ Coverage 36.53% 41.98% +5.45%
==========================================
Files 42 42
Lines 906 936 +30
Branches 205 233 +28
==========================================
+ Hits 331 393 +62
+ Misses 575 543 -32
Flags with carried forward coverage won't be shown. Click here to find out more. |
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. |
identity-apps-core/pom.xml
Outdated
@@ -729,7 +734,7 @@ | |||
<carbon.extension.identity.authenticator.version>3.0.0</carbon.extension.identity.authenticator.version> | |||
<org.wso2.carbon.identity.association.account>5.1.5</org.wso2.carbon.identity.association.account> | |||
<identity.extension.utils>1.0.8</identity.extension.utils> | |||
<carbon.identity.framework.version>7.2.30</carbon.identity.framework.version> | |||
<carbon.identity.framework.version>7.7.142-SNAPSHOT</carbon.identity.framework.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need changeset?
Proposed changes in this pull request
Previously, newly added scopes to the API resource collection did not reflect in existing console roles. With this PR (wso2/carbon-identity-framework#6372), we have introduced a new collection version and set previous collection as v0, which includes two feature scopes used for collection viewing and editing.
Following is sample api resource collection (v0 one and new one)
In this PR we have introduce a listener to resolve console role permission at runtime.
When we fetch a console role, this listener :
When adding or updating role (with permission) now we only persist new feature scope. In get role level we will resolve actual permissions of the role with api collection. This will resolve the original problem
Related Issues
Merge After