Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Failure API tests for user defined federated authenticator management #21814

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Shenali-SJ
Copy link
Contributor

@Shenali-SJ Shenali-SJ commented Nov 25, 2024

Proposed changes in this pull request

This PR adds API tests to validate failure scenarios for IdPs with user-defined authenticators.

Related Issue:

Related PR:


Checklist (for reviewing)

General

  • Is this PR explained thoroughly? All code changes must be accounted for in the PR description.
  • Is the PR labeled correctly?

Functionality

  • Are all requirements met? Compare implemented functionality with the requirements specification.
  • Does the UI work as expected? There should be no Javascript errors in the console; all resources should load. There should be no unexpected errors. Deliberately try to break the feature to find out if there are corner cases that are not handled.

Code

  • Do you fully understand the introduced changes to the code? If not ask for clarification, it might uncover ways to solve a problem in a more elegant and efficient way.
  • Does the PR introduce any inefficient database requests? Use the debug server to check for duplicate requests.
  • Are all necessary strings marked for translation? All strings that are exposed to users via the UI must be marked for translation.

Tests

  • Are there sufficient test cases? Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components.
  • If this is a bug fix, are tests for the issue in place? There must be a test case for the bug to ensure the issue won’t regress. Make sure that the tests break without the new code to fix the issue.
  • If this is a new feature or a significant change to an existing feature? has the manual testing spreadsheet been updated with instructions for manual testing?

Security

  • Confirm this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • Are all UI and API inputs run through forms or serializers?
  • Are all external inputs validated and sanitized appropriately?
  • Does all branching logic have a default case?
  • Does this solution handle outliers and edge cases gracefully?
  • Are all external communications secured and restricted to SSL?

Documentation

  • Are changes to the UI documented in the platform docs? If this PR introduces new platform site functionality or changes existing ones, the changes should be documented.
  • Are changes to the API documented in the API docs? If this PR introduces new API functionality or changes existing ones, the changes must be documented.
  • Are reusable components documented? If this PR introduces components that are relevant to other developers (for instance a mixin for a view or a generic form) they should be documented in the Wiki.

@Shenali-SJ Shenali-SJ force-pushed the custom-fed-mgt-integration-tests branch 2 times, most recently from 373a4f2 to 415ee59 Compare November 28, 2024 20:01
@Shenali-SJ Shenali-SJ changed the title Add API tests for user defined federated authenticator management Add Failure API tests for user defined federated authenticator management Nov 30, 2024
@Shenali-SJ Shenali-SJ force-pushed the custom-fed-mgt-integration-tests branch from 415ee59 to f989e04 Compare November 30, 2024 15:13
@Shenali-SJ Shenali-SJ force-pushed the custom-fed-mgt-integration-tests branch from 204aaea to 5d7bd4f Compare December 1, 2024 15:32
@Shenali-SJ Shenali-SJ marked this pull request as ready for review December 1, 2024 17:01
@Shenali-SJ Shenali-SJ force-pushed the custom-fed-mgt-integration-tests branch 2 times, most recently from 9a3f1bc to 53c5cf7 Compare December 2, 2024 04:35
@Shenali-SJ Shenali-SJ force-pushed the custom-fed-mgt-integration-tests branch from e24b571 to 8a8a7e3 Compare December 3, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants