Update SelfSignUpConsentTest with Tenanted Callback Endpoint and Assertion Adjustments
#22154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Jan 5, 2025
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12616515197
DilshanSenarath
approved these changes
Jan 5, 2025
Comment on lines
+68
to
+69
| private static final String CALLBACK_ENDPOINT = "https://localhost:9853/carbon/callback"; | ||
| private static final String TENANTED_CALLBACK_ENDPOINT = "https://localhost:9853/t/wso2.com/carbon/callback"; |
There was a problem hiding this comment.
Let's use port and secondary domain name from already available constants. You can add a new PR with this suggestion.
There was a problem hiding this comment.
Addressed using #22158
This was referenced Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request includes changes to the
SelfSignUpConsentTestclass in theorg.wso2.identity.integration.test.consentpackage to update the callback endpoints and adjust the corresponding test assertions.Changes to callback endpoints:
CALLBACK_ENDPOINTto use the correct port (https://localhost:9853/carbon/callback).TENANTED_CALLBACK_ENDPOINTfor tenant specific callback URL (https://localhost:9853/t/wso2.com/carbon/callback).Adjustments to test assertions:
testInitialSelfSignUpPagemethod to assert the presence of theTENANTED_CALLBACK_ENDPOINTinstead ofCALLBACK_ENDPOINT.Related PRs