Fix not sending fault response when Endpoint TO #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malakaganga
force-pushed
the
fix_timeout_res
branch
from
44a129b to
9f2ce2a
Compare
While reading the request if a endpoint time out happens the fault sequence response is not written to the back end. The reason for this is the thread is remaining actively in SourceHandler inputReady method while reading request when timeout happens so it would never hit responseReady method until the thread is released. So I achieved that by suspending the input when timeout happens. Also important aspect here is that this is a error scenario since we haven't read input completely hence haven't sent request data completely hence we need to avoid returning the buffers to the buffer factory as well. Fixes: wso2/api-manager#2499 imp2
malakaganga
force-pushed
the
fix_timeout_res
branch
from
9f2ce2a to
de06077
Compare
isudana
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
While reading the request if an endpoint time-out happens the fault sequence response is not written to the back end. The reason for this is the thread is remaining actively in the SourceHandler inputReady method while reading requests when timeout happens so it would never hit the responseReady method until the thread is released. So I achieved that by suspending the input when timeout happens.
Also, an important aspect here is that this is an error scenario since we haven't read the input completely and hence haven't sent request data completely as well.
Hence we need to avoid returning the buffers to the buffer factory as well.
Fixes: wso2/api-manager#2499