Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expression support to endpoint definition attributes for handling endpoints in the HTTP connector. #2238

Conversation

chathuranga-jayanath-99
Copy link
Contributor

@chathuranga-jayanath-99 chathuranga-jayanath-99 commented Nov 26, 2024

Purpose

The HTTP connector uses the following format for maintaining endpoint definitions. To support this format, expression support for endpoint definition attributes is required. This PR introduces the necessary changes to enable this support for the use of HTTP connector. Note that expression support for timeout-duration is already available.

<http method="get" uri-template="{uri.var.base}{+uri.var.path}{+uri.var.query}">
  <timeout>
      <duration>{get-property('timeoutDuration')}</duration>
      <responseAction>{get-property('timeoutAction')}</responseAction>
  </timeout>
  <suspendOnFailure>
      <errorCodes>{get-property('suspendErrorCodes')}</errorCodes>
      <initialDuration>{get-property('suspendInitialDuration')}</initialDuration>
      <maximumDuration>{get-property('suspendMaximumDuration')}</maximumDuration>
      <progressionFactor>{get-property('suspendProgressionFactor')}</progressionFactor>
  </suspendOnFailure>
  <markForSuspension>
      <errorCodes>{get-property('retryErrorCodes')}</errorCodes>
      <retriesBeforeSuspension>{get-property('retryCount')}</retriesBeforeSuspension>
      <retryDelay>{get-property('retryDelay')}</retryDelay>
  </markForSuspension>
</http>

@GDLMadushanka
Copy link
Contributor

Please squash these commits to a single one

@chathuranga-jayanath-99 chathuranga-jayanath-99 changed the title Add support for expressions in endpoint definition attributes. Add expression support to endpoint definition attributes for handling endpoints in the HTTP connector. Dec 10, 2024
@arunans23
Copy link
Member

Shall we explore whether we can resolve the values at the first request and use them for consecutive requests? Also lets try to do it for HTTP Endpoint only so that we do not have to modify the behaviour of other endpoint types.

@chathuranga-jayanath-99
Copy link
Contributor Author

To handle the endpoints required for the HTTP connector, it was agreed that deploying the endpoints during the local entry deployment would be a better approach than making every field dynamic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants