Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assessment is spelt incorrectly as "assessement" in DDL #200

Open
kjsanger opened this issue Sep 13, 2021 · 4 comments
Open

assessment is spelt incorrectly as "assessement" in DDL #200

kjsanger opened this issue Sep 13, 2021 · 4 comments
Labels

Comments

@kjsanger
Copy link
Member

This occurs in a both the DDL and code e.g. in IseqExternalProductMetric. Flagged by spell-checking in an IDE.

@kjsanger kjsanger added the bug label Sep 13, 2021
@kjsanger
Copy link
Member Author

Other typos in comments:

delimited as "delimitered"
unambiguously as "unambigiously"
"exection"
Instrument as "Instument"

@mgcam
Copy link
Member

mgcam commented Sep 13, 2021

Why is this classified as a bug? Is there a failure anywhere in the process?

@kjsanger
Copy link
Member Author

When I spelled it correctly in a query, I got an error about an unknown column. It isn't consistent across columns, so it's not just a case of consistently spelling it with an extra "e".

contamination_assessment,
overrepresented_sequences_assessement 

@dkj
Copy link
Member

dkj commented Sep 13, 2021

There will be more risk/cost in fixing this than leaving it given the flag day required for a change, currently unknown downstream use and changes required, and limited lifetime (Jan/Feb 2022) of the associated project. Recommend we live with the bad column names until the table is deprecated at end of the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants