#292 | Service Check - Add diff on expected vs actual body #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mGasiorek998
changed the title
| {bodyMessage === 'NO MATCH' ? ( | ||
| <StyledPopoverTextWrapper> | ||
| <StyledPopoverText> | ||
| <StyledPopoverHeader>EXPECTED RESPONSE BODY</StyledPopoverHeader> |
There was a problem hiding this comment.
just EXPECTED RESPONSE and ACTUAL RESPONSE
There was a problem hiding this comment.
Yeah and please move this to const too
There was a problem hiding this comment.
Fixed in commit 297f448
szymon-owczarzak
previously approved these changes
Jun 23, 2021
szymon-owczarzak
changed the title
| @@ -39,7 +46,20 @@ export const PopoverWithControls = ({ | |||
| > | |||
| {withCopy ? <Button onClick={copyBody}>Copy</Button> : null} | |||
| <Button onClick={handlePopoverClose}>Close</Button> | |||
| <StyledPopoverText>{body}</StyledPopoverText> | |||
| {bodyMessage === 'NO MATCH' ? ( | |||
There was a problem hiding this comment.
You can move 'NO MATCH' string to const
There was a problem hiding this comment.
Fixed in commit 297f448
| {expectedResponseBody} | ||
| </StyledPopoverText> | ||
| <StyledPopoverText> | ||
| <StyledPopoverHeader>RECIVED RESPONSE BODY</StyledPopoverHeader> |
There was a problem hiding this comment.
I guess you wanted to write 'RECEIVED' here
There was a problem hiding this comment.
Fixed in commit 297f448
| @@ -128,12 +128,29 @@ export const StyledFormControl = styled(FormControl)` | |||
| max-width: 300px; | |||
| `; | |||
|
|
|||
| export const StyledPopoverText = styled(Typography)` | |||
| export const StyledPopoverText = styled('div')` | |||
There was a problem hiding this comment.
When you create a styled component for html selector you can simply write
Suggested change
| export const StyledPopoverText = styled('div')` | |
| export const StyledPopoverText = styled.div` |
There was a problem hiding this comment.
Fixed in commit 297f448
szymon-owczarzak
previously approved these changes
Jun 28, 2021
YellowFlash525
previously approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#292 Widget | Service Check - Add diff on expected vs actual body
Description
Added split view for Request and Expected Response body when Responses do not match.
Motivation and Context
Thanks to split view user will be able to quickly diagnose what was expected and what was recived.
Screenshots (if appropriate)
Types of changes
Checklist:
I hereby agree to the terms of the Cogboard Contributor License Agreement.