Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#356 - Widget | ToDo list - enter key support while adding items #368

Merged

Conversation

marcin-witaszek-wttech
Copy link
Collaborator

@marcin-witaszek-wttech marcin-witaszek-wttech commented Apr 23, 2021

Description

Currently in edit dialog for ToDo List widget when user is focused on Item Title text field nad hits enter, the dialog closes. This PR changes this behaviour so the enter key simply confirms addition/update of list item.

#356

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • Automated functional tests have been added or modified to cover my changes (if applicable)
  • I have updated the documentation accordingly.

I hereby agree to the terms of the Cogboard Contributor License Agreement.

@GrzegorzBednarski GrzegorzBednarski merged commit a700e7e into master Apr 30, 2021
@GrzegorzBednarski GrzegorzBednarski deleted the todo-list-enter-key-support-while-adding-items branch April 30, 2021 10:11
@szymon-owczarzak szymon-owczarzak added the enhancement New feature or request label May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants