refactor(api): Improve structure of TelestionVerticle
#539
+84
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb0s
added
🌷 enhancement
|
I think we should probably convert this PR to "draft" until we finish the debate in #538 😉 |
|
Sounds good to me :) |
|
@cb0s Can I close this PR due to recent inactivity? |
pklaschka
force-pushed
the
main
branch
2 times, most recently
from
8871be5 to
b78e9a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I reordered the fields and methods according to the rules I proposed in #538 . This should make the API cleaner imo. Please tell me what you think.
Related links
CLA