Deleting dashboards (TELESTION-458) and changing their names (TELESTION-459) #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 24, 2024
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
pklaschka
force-pushed
the
01-21-TELESTION-462_Make_widgets_configurable
branch
from
98b46ec
to
52a2a56
Compare
pklaschka
force-pushed
the
01-24-Deleting_dashboards_TELESTION-458_and_changing_their_names_TELESTION-459_
branch
from
559d56d
to
2ff81ca
Compare
pklaschka
force-pushed
the
01-21-TELESTION-462_Make_widgets_configurable
branch
from
52a2a56
to
7d56f8c
Compare
pklaschka
force-pushed
the
01-24-Deleting_dashboards_TELESTION-458_and_changing_their_names_TELESTION-459_
branch
from
2ff81ca
to
0858995
Compare
pklaschka
force-pushed
the
01-21-TELESTION-462_Make_widgets_configurable
branch
from
7d56f8c
to
ab9249e
Compare
pklaschka
force-pushed
the
01-24-Deleting_dashboards_TELESTION-458_and_changing_their_names_TELESTION-459_
branch
from
0858995
to
bba5a4b
Compare
pklaschka
force-pushed
the
01-21-TELESTION-462_Make_widgets_configurable
branch
from
ab9249e
to
07d2c59
Compare
pklaschka
force-pushed
the
01-24-Deleting_dashboards_TELESTION-458_and_changing_their_names_TELESTION-459_
branch
from
bba5a4b
to
21d1648
Compare
pklaschka
force-pushed
the
01-21-TELESTION-462_Make_widgets_configurable
branch
from
07d2c59
to
8778084
Compare
pklaschka
force-pushed
the
01-24-Deleting_dashboards_TELESTION-458_and_changing_their_names_TELESTION-459_
branch
from
21d1648
to
e58cf33
Compare
pklaschka
force-pushed
the
01-21-TELESTION-462_Make_widgets_configurable
branch
from
8778084
to
5a72697
Compare
pklaschka
force-pushed
the
01-24-Deleting_dashboards_TELESTION-458_and_changing_their_names_TELESTION-459_
branch
from
e58cf33
to
7d47eba
Compare
pklaschka
force-pushed
the
01-21-TELESTION-462_Make_widgets_configurable
branch
from
5a72697
to
c271b9e
Compare
Base automatically changed from
01-21-TELESTION-462_Make_widgets_configurable
to
main
January 26, 2024 18:45
…ON-459) This change 1. adjusts the existing editing route (`POST` / `PUT` on `/dashboards/:dashboardId/edit`) to make the dashboard title editable and adds a text field to achive this to the corresponding UI 2. adds a `DELETE` action on the same route to delete the dasboard with the ID `:dashboardId`. This redirects to `/`, which in turn redirects either to the first available dashboard or, if none exists, a corresponding page. Note that the Browser's native `window.confirm()` was used to ask the user whether they really want to delete the dashboard. This can, eventually, be replaced by a better integrated UI, but for the MVP, works as-is without any issues.
pklaschka
force-pushed
the
01-24-Deleting_dashboards_TELESTION-458_and_changing_their_names_TELESTION-459_
branch
from
7d47eba
to
11f8f3b
Compare
Merge activity
|
pklaschka
deleted the
01-24-Deleting_dashboards_TELESTION-458_and_changing_their_names_TELESTION-459_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change
POST/PUTon/dashboards/:dashboardId/edit) to make the dashboard title editable and adds a text field to achive this to the corresponding UIDELETEaction on the same route to delete the dasboard with the ID:dashboardId. This redirects to/, which in turn redirects either to the first available dashboard or, if none exists, a corresponding page.Note that the Browser's native
window.confirm()was used to ask the user whether they really want to delete the dashboard. This can, eventually, be replaced by a better integrated UI, but for the MVP, works as-is without any issues.