Fix #663: Add Mobile Token documentation #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banterCZ
reviewed
Feb 13, 2023
| "amount": 100, | ||
| "currency": "CZK", | ||
| "amountFormatted": "100,00", | ||
| "currencyFormatted": "Kč" |
There was a problem hiding this comment.
I will document this later on based on the result of discussion at #669
banterCZ
reviewed
Feb 13, 2023
| | `KEY_VALUE` | Form field representing a key value item, where items are displayed next to each other. This realistically impose limitation on value length - it should fit into the single line. | | ||
| | `NOTE` | Form field representing a generic text note, where label is displayed above the note. As a result, note can be of an arbitrary length and can be multi-line. | | ||
| | `HEADING` | Form field representing a heading, where label is displayed as the heading text. | | ||
| | `PARTY_INFO` | Form field representing a structured object with information about a third party. | |
There was a problem hiding this comment.
I have opened an issue to document missing types #671
banterCZ
reviewed
Feb 13, 2023
docs/Offline-Signatures-QR-Code.md
Outdated
|
|
||
| | Flag | Meaning | | ||
| |------|:-----------------------------| | ||
| | `B` | Operation can be signed with biometric factor | |
There was a problem hiding this comment.
If QR code documentation will be part of enrollment documentation, we should also document new flags introduced in 1.4.0; It may be another issue and PR.
There was a problem hiding this comment.
I think I will add it for now, just for the sake of having all documentation related to operation data (online / offline) and operation form data in one place. We can revise this later, if needed.
banterCZ
reviewed
Feb 13, 2023
| ## Value Formatting | ||
|
|
||
| Following form data attributes support value formatting: | ||
| - `AMOUNT` |
There was a problem hiding this comment.
👀 #669 is focused only on the amount formatting.
banterCZ
reviewed
Feb 13, 2023
banterCZ
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.