Skip to content

Custom affinities and tolerations #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Jancis
Copy link
Member

@Jancis Jancis commented Jun 18, 2025

Allows definition of custom node and pod affinities, along with tolerations.

  • Current drupal affinities moved from drupal template to values
  • Current tolerations, created by inverse nodeSelector rules are kept, provides backwards compatibility with current nodeSelector rules
  • Removes empty resources sections when no value present, instead of setting them to {}

Testing done with helm unittest and manually, by defining php.nodeSelector, php.tolerations, php.affinity, php.cron.nodeSelector, php.cron.tolerations, and php.cron.affinity values in various combinations, confirming expected output with helm template command.

@Jancis Jancis requested a review from Rade333 June 18, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant