Skip to content

SLT-1193: Frontend chart: Remove deprecated mailhog service from the chart #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

k4lv15
Copy link
Contributor

@k4lv15 k4lv15 commented May 19, 2025

Changes proposed:

How to test:

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated mailhog service configurations from the chart and associated files, ensuring that only mailpit remains for email handling.

  • Removed mailhog configuration values and schema definitions from values.yaml and values.schema.json
  • Deleted mailhog-specific logic in template files (varnish, configmap, checks, and helpers) and corresponding documentation in NOTES.txt
  • Updated Chart.yaml and CI configuration to remove mailhog dependencies and repositories

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
charts/frontend/values.yaml Removed mailhog configuration blocks
charts/frontend/values.schema.json Removed mailhog schema definitions
charts/frontend/templates/varnish-configmap-vcl.yaml Removed mailhog routing logic from varnish configuration
charts/frontend/templates/configmap.yaml Removed mailhog location block and replaced it with mailpit redirection
charts/frontend/templates/checks.yaml Removed mailhog validation checks
charts/frontend/templates/_helpers.tpl Removed mailhog naming validations
charts/frontend/templates/NOTES.txt Deleted mailhog documentation notes
charts/frontend/Chart.yaml Removed mailhog dependency from chart metadata
.circleci/config.yml Updated helm repository configurations to match the removal
Comments suppressed due to low confidence (1)

charts/frontend/templates/configmap.yaml:168

  • It would be helpful to add an inline comment clarifying that the '/mailhog' location block now serves exclusively to redirect legacy traffic to mailpit, to assist future maintainers.
location /mailhog {

@k4lv15 k4lv15 marked this pull request as ready for review May 19, 2025 14:06
@k4lv15 k4lv15 marked this pull request as draft May 26, 2025 08:49
@k4lv15
Copy link
Contributor Author

k4lv15 commented May 26, 2025

Postponed until mailhog is properly deprecated in #148, marking as draft for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant