Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KAFKA_CONFIGS variable to do additional configuration #333

Closed
wants to merge 4 commits into from
Closed

Add KAFKA_CONFIGS variable to do additional configuration #333

wants to merge 4 commits into from

Conversation

raarts
Copy link

@raarts raarts commented May 23, 2018

I needed more specific per-topic settings.
This PR allows using the kafka-configs.sh script during creation time.

@sscaling
Copy link
Collaborator

@raarts
Copy link
Author

raarts commented May 23, 2018

I see the test, but I can't explain how it works, where is the extra --config parameter parsed in create-config.sh (looking at https://github.com/wurstmeister/kafka-docker/blob/master/create-topics.sh)

Does kafka-topics.sh accept multiple --config arguments? I remember trying and it did not work.
Also, this isn't documented in the readme.

EDIT: ok, I think I understand now. Should be documented better.

@sscaling
Copy link
Collaborator

Yes - admittedly it's not obvious, but implemented to support backwards compatibility.

test:2:1:compact --config=<x> --config=<y> --config=<z>

Where compact is topic compaction policy. Documentation of this is an existing issue: #311

@sscaling
Copy link
Collaborator

ok, I think I understand now. Should be documented better.

happy to close this PR?

@raarts raarts closed this May 23, 2018
@sscaling
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants