Echarlie 32 bootstrap4 #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutantmonkey
requested changes
Feb 11, 2022
There was a problem hiding this comment.
I haven't tried this out in a browser yet, but I assume you have. It looks like there's one typo that should be fixed before we merge this.
BTW, we may want to evaluate whether or not it's appropriate to include the .map files and other Bootstrap files we aren't using. I'm fine with doing it, but it is going to lead to larger Docker images than necessary. For now, I'll leave that up to you.
| @@ -1,15 +1,15 @@ | |||
| {% extends "admin/base.html" %} | |||
| {% set page_title="Roles" %} | |||
| {% block nav_admin_roles %}<li class="active"><a href="{{ url_for('admin.roles') }}">Roles</a></li>{% endblock %} | |||
| {% block nav_admin_roles %}<li class="nav=item"><a class="nav-link active" href="{{ url_for('admin.roles') }}">Roles</a></li>{% endblock %} | |||
There was a problem hiding this comment.
Shouldn't this be nav-item?
There was a problem hiding this comment.
yup. looks like it should be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
substantial rewrite of templates to support bootstrap 5. fixes #32
Major changes:
see https://getbootstrap.com/docs/4.6/migration/ and https://getbootstrap.com/docs/5.0/migration