Report on HTTP Status with descriptive string #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of just the integer code
|
@wvanbergen What do you think? |
| @@ -1,3 +1,3 @@ | |||
| module RequestLogAnalyzer | |||
| VERSION = '1.13.4' | |||
| VERSION = '1.13.5' | |||
There was a problem hiding this comment.
Please don't update the VERSION constant - this is done as part of the release process.
|
Just a small nitpick, this looks good to me. |
|
No worries. Seems like I misread the contribution instructions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the report gives a frequency of "200" or "406" or whatever. Some HTTP Codes are obscure and are always a bit hard to remember. This change request ensure that they get aggregated and reported as "200 OK" or "404 Not Found" etc.