-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change webcam icon to point in the direction the webcam is facing #21
Conversation
Hello, Thanks for creating this merge request. The idea is good, and I would like to add it. I have a few requests before we can merge the changes. First, the good. I like the extra information it brings to the map. I also like the way it uses multiple tags to determine the direction. Here is a list of things that need to be fixed before I can merge it.
Thanks again for supplying this PR, and I look forward to the fixes and merging it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hate to do this to you. And I'm always displeased when somebody has another round of comments for me.
I've updated all the notes and checked if they are still valid. The effort is appreciated.
ebdcf62
to
e1b6e25
Compare
Co-authored-by: wouter van der plas <[email protected]>
Co-authored-by: wouter van der plas <[email protected]>
e1b6e25
to
c9bf0b8
Compare
c9bf0b8
to
49bb94e
Compare
First of all, thank you for making this. Sorry for the mess I've made of the PR. I wanted to rebase and had some git mishaps along the way. I also put some finishing touches on the code myself. You can find them in 49bb94e. Thank you for having this idea and taking the time to implement it. |
Very nice. I love the new "grouping" feature on zoom out. Thank for starting this project. |
I think it's very useful to see on the map already what direction a webcam is facing, and this data is often available.
To this end I changed the icon to be more directional (svg taken from https://de.wikipedia.org/wiki/Datei:Video_camera_icon_svg.svg) and rotated it appropriately.