Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change overpass filter to only look for contact:webcam. #22

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

wmbr
Copy link
Contributor

@wmbr wmbr commented Nov 14, 2023

I found that many webcams are only tagged man_made=surveillance and not surveillance=webcam (e.g. https://www.openstreetmap.org/node/9569388016)
I think simply filtering by contact:webcam=* is sensible since having a public feed is ultimately the relevant criterion.
Also I narrowed it down to only nodes (can webcams be areas or paths? how would we display these?)

Many webcams are only tagged man_made=surveillance and not surveillance=webcam. Having a webcam feed url should be the relevant criterion ultimately.
@wvanderp
Copy link
Owner

wvanderp commented Nov 15, 2023

Thank you so much for bringing this to my attention and for providing a fix.
I will merge this to give you the recognition you deserve, and this also triggered many changes for me.

I ran the old and new queries in Overpass, which returned a different set of cameras. So I thought, "Why Not Both?" so I combined the queries to go from 1000 webcams to 5000. so, thanks for mentioning this.

Overpass has the center output type that returns all elements as a node in the center of the thing. So I will use that.

Lastly, I have the query in the repo's root and the URL you edited, so I now read the file at the root.

You can see all the changes you triggered in 44df2db

I want to thank you again. you both found an issue and fixed it. not many people take the time to do that.

@wvanderp wvanderp merged commit 8aed65c into wvanderp:master Nov 15, 2023
6 checks passed
@wmbr
Copy link
Contributor Author

wmbr commented Nov 17, 2023

Thanks for your kind words :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants