-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: run unittests after build #2681
base: master
Are you sure you want to change the base?
Conversation
f687715
to
7442197
Compare
For the hanging test, what is the pattern that should be used when running without an user interaction? In the following, showing a modal dialog has no apparent way of getting closed. Phoenix/unittests/test_filedlgcustomize.py Lines 9 to 22 in 5abeba2
|
@echoix this line should cause the modal to be closed after 250 ms (I think):
I haven't investigated yet why the Windows tests are hanging - is this the reason? |
If it were to be a deadlock caused by multiprocessing and the startup method, we might've been able to see something similar on macOS too. Was the job retried and jams at the same place? |
Last time I debugged something similar, I had to go by bisection to find what test where actually causing to jam, as it's not always the ones we see. If I remember correctly, there was also something to do with the fact that the shell used in the CI was cmd, and is quite limited on error reporting. The test was already failed, but the error didn't display yet, waiting for some input on some stream, and then times out, and further gets force killed (when seeing the ^C). It's probably not as worse as it looks like. |
I've done some more runs on a PR against my fork: echoix#21 So I tried skipping the hanging tests to see what else there was, or if there was a pattern. I added other python versions for windows x64, and nothing else failed or hung. Once the CI is finished I'll try to push again to narrow what python versions hang, and also see which ones of the three richmsgdlg_Tests fail. Three of them use dlg.ShowModal() and wx.CallLater() too. |
7442197
to
f3c71ca
Compare
This was originally added when numpy didn't support Python 3.12, but that has long since been resolved.
f3c71ca
to
bf5d8b7
Compare
There are probably going to be failures, but would be good to know where we are.